-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HighlightConverter does not honor {STYLE_NAME} configuration #1545
Comments
Hi @zartc, As documented the correct syntax is:
I wouldn't complexify the syntax to accept just "LOGBACK". There should be probably a warning if a user employs an incorrect syntax (without |
If @zartc doesn't mind, I can add the necessary warning message. |
@aawad6, go ahead! |
@zartc, thanks so much for the report! 🙇 The issue is fixed. It will be available with the next release. |
Description
When using the HighlightConverter like this:
%highlight{%5level}{LOGBACK}
the HighlightConverter always uses the colors of the DEFAULT preset instead of the color of the LOGBACK as asked.Configuration
Version: 2.20.0
Operating system: Windows 10
JDK: temirun-11
Logs
none
Reproduction
Configure a converter with:
%highlight{%5level}{LOGBACK}
You will discover that the HighlightConverter always uses the colors of the DEFAULT preset.
Fixe
HighlightConverter.createLevelStyleMap()
method is missing a check at line 151 to see if the passedoptions[1]
contains a map of LEVEL=color or a preset style name.The text was updated successfully, but these errors were encountered: