[K8S][HELM] Align Helm templates with formatting approach

[dnskr]

🔍 Description

Issue References 🔗

There are few formatting misalignments in the Helm chart.

Describe Your Solution 🔧

The PR aligns the chart templates formatting without any functional changes.

Types of changes 🔖

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Test 1

All templates (and rendered labels) are correct with default chart values:

helm template --debug charts/kyuubi

Test 2

Templates kyuubi-alert.yaml, kyuubi-podmonitor.yaml and kyuubi-servicemonitor.yaml are correct with additionally provided values:

helm template --debug charts/kyuubi -f values-monitoring.yaml -s templates/kyuubi-alert.yaml -s templates/kyuubi-podmonitor.yaml -s templates/kyuubi-servicemonitor.yaml

File values-monitoring.yaml used for testing

metricsReporters: PROMETHEUS

podMonitor:
  enabled: true
  podMetricsEndpoint:
    - port: web

serviceMonitor:
  enabled: true
  endpoints:
    - port: web
  labels:
    first: label1
    second: label2

prometheusRule:
  enabled: true
  groups:
    - name: ./example.rules
      rules:
        - alert: ExampleAlert
          expr: vector(1)

---

Checklist 📝

• This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

[pan3793]

well, but the previous one is more intuitive for me, since the rendered result of template

  labels:
    {{- include "kyuubi.labels" . | nindent 4 }}

is something like

  labels:
    label1: value1
    label2: value2

any specify reason to use the proposed one?

[dnskr]

There is no specific reason, rather than following one style across all templates. The idea is to keep templates more compact if it is possible. We use this formatting style in many places, for instance:

kyuubi/charts/kyuubi/templates/kyuubi-role.yaml

Line 25 in 0a53415

rules: {{- toYaml .Values.rbac.rules | nindent 2 }}

kyuubi/charts/kyuubi/templates/kyuubi-service.yaml

Line 27 in 0a53415

annotations: {{- toYaml . | nindent 4 }}

kyuubi/charts/kyuubi/templates/kyuubi-service.yaml

Line 44 in 0a53415

sessionAffinityConfig: {{- toYaml . | nindent 4 }}

[pan3793]

I agree to unify the style, but lean to invert the style.

[dnskr]

There is no strong convention at the moment as far as I know, so both approaches are valid. Personally I prefer more compact style, because from my experience it's more convenient to read and review the code, especially if a template has many lines. One argument here might be that Bitnami uses this approach as well for all their charts.