[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

zhouyifan279 · 2024-06-04T12:15:46Z

🔍 Description

Issue References 🔗

This pull request fixes Gluten CI Error ClassNotFoundException: io.glutenproject.GlutenPlugin

Describe Your Solution 🔧

Change spark.plugins's property value from io.glutenproject.GlutenPlugin to org.apache.gluten.GlutenPlugin.

Types of changes 🔖

Bugfix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklist 📝

This patch was not authored or co-authored using Generative Tooling

Be nice. Be informative.

zhouyifan279 · 2024-06-04T12:20:36Z

@pan3793 How can I tigger Gluten CI in this PR ?

pan3793 · 2024-06-04T12:24:58Z

You can modify

kyuubi/.github/workflows/gluten.yml

Lines 20 to 22 in 1fb1f85

    
           on: 
        
             schedule: 
        
               - cron: 0 4 * * *

zhouyifan279 · 2024-06-04T13:01:44Z

You can modify

kyuubi/.github/workflows/gluten.yml

Lines 20 to 22 in 1fb1f85

on:

schedule:

- cron: 0 4 * * *

@pan3793 Thanks. I was hoping there was a button on some web page. But it looks like there is no such button.

pan3793 · 2024-06-04T13:15:48Z

technically, we can allow the job to be triggered manually, then there will be a button.

codecov-commenter · 2024-06-04T14:03:03Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (1fb1f85) to head (284861d).
Report is 29 commits behind head on master.

❗ Current head 284861d differs from pull request most recent head a3415c8

Please upload reports for the commit a3415c8 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (1fb1f85) and HEAD (284861d). Click for more details.

HEAD has 5 uploads less than BASE

Flag BASE (1fb1f85) HEAD (284861d)

6 1

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #6449       +/-   ##
============================================
- Coverage     58.34%   0.00%   -58.35%     
============================================
  Files           656     677       +21     
  Lines         40264   41734     +1470     
  Branches       5498    5704      +206     
============================================
- Hits          23493       0    -23493     
- Misses        14272   41734    +27462     
+ Partials       2499       0     -2499

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…:jar

zhouyifan279 · 2024-06-10T08:28:25Z

.github/workflows/gluten.yml

@@ -20,6 +20,10 @@ name: Gluten CI
 on:
  schedule:
    - cron: 0 4 * * *
+  pull_request:


Remove this before merge

pan3793 · 2024-06-11T02:04:05Z

integration-tests/kyuubi-gluten-it/pom.xml

+            <!-- provides os.detected.classifier (i.e. linux-x86_64, osx-x86_64) property -->
+            <extension>
+                <groupId>kr.motd.maven</groupId>
+                <artifactId>os-maven-plugin</artifactId>


we're likely to reuse this plugin for proto file gen, let's pullout it to the root pom

pan3793 · 2024-06-11T02:06:20Z

.github/workflows/gluten.yml

+            VERSION=$(. /etc/os-release && echo ${VERSION_ID})
+            ARCH=`uname -m`
+            mkdir -p $THIRDPARTY_LIB
+            cp /usr/lib/${ARCH}-linux-gnu/{libre2.so.9,libdouble-conversion.so.3,libidn.so.12,\


why should we do such copy? /usr/lib/${ARCH}-linux-gnu should be included in ld.so.conf

Build and test are run in different vm. Libraries only exists in build vm.

pan3793 · 2024-06-11T02:40:07Z

.github/workflows/gluten.yml

@@ -64,6 +68,18 @@ jobs:
            git clone https://github.com/oap-project/gluten.git


this repo should be updated.

pan3793 · 2024-06-11T02:40:41Z

I don't have further questions, would like @ulysses-you to take a look.

ulysses-you · 2024-06-11T02:44:35Z

.github/workflows/gluten.yml

+          libldap-2.5.so.0,liblber-2.5.so.0,libntlm.so.0,librtmp.so.1,libsasl2.so.2,libssh.so.4,\
+          libicudata.so.70,libthrift-0.16.0.so} $THIRDPARTY_LIB/
+            cp /usr/local/lib/{libprotobuf.so.32,libboost_context.so.1.84.0,\
+          libboost_regex.so.1.84.0} $THIRDPARTY_LIB/


Can we send a pr to gluten to make package.sh support collect libraries only ? So that we can use that script directly.

OK. Let me try.

zhouyifan279 · 2024-06-25T15:58:08Z

@pan3793 @ulysses-you I have fixed the errors in gluten project build script ./dev/package.sh and use it in kyuubi's gluten ci to generate both gluten jars and gluten libs(.so files). Job gluten-build now works fine.

But Job gluten-it always throws the following error:

#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007f47b5c75994, pid=24169, tid=0x00007f47237ff640
#
# JRE version: OpenJDK Runtime Environment (8.0_412-b08) (build 1.8.0_412-b08)
# Java VM: OpenJDK 64-Bit Server VM (25.412-b08 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libgcc_s.so.1+0x14994]  _Unwind_GetTextRelBase+0x4
#
# Core dump written. Default location: /home/runner/work/kyuubi/kyuubi/integration-tests/kyuubi-gluten-it/core or core.24169
#
# An error report file with more information is saved as:
# /home/runner/work/kyuubi/kyuubi/integration-tests/kyuubi-gluten-it/hs_err_pid24169.log
#
# If you would like to submit a bug report, please visit:
#   https://github.com/adoptium/adoptium-support/issues
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#

It seems to be caused by Gluten's cpp code.
I'm not familiar with Gluten's cpp code. I hope we can have a gluten expert to fix this.

I've uploaded the jvm error report files as artifacts. It may help the debugging.

gluten-it-spark-3.3: https://github.com/apache/kyuubi/actions/runs/9647616234/artifacts/1632774211
gluten-it-spark-3.4: https://github.com/apache/kyuubi/actions/runs/9647616234/artifacts/1632774213

ulysses-you · 2024-06-26T02:06:11Z

.github/workflows/gluten.yml

@@ -61,9 +65,9 @@ jobs:
      - name: Build gluten project


Try remove libunwind-dev at line46

OK. Let me try.

@ulysses-you It failed at StepInstall dependencies.

+ sudo --preserve-env apt install -y libc-ares-dev libcurl4-openssl-dev libssl-dev libicu-dev libdouble-conversion-dev libgoogle-glog-dev libbz2-dev libgflags-dev libevent-dev liblz4-dev libzstd-dev libre2-dev libsnappy-dev libsodium-dev libthrift-dev liblzo2-dev libelf-dev libdwarf-dev bison flex libfl-dev tzdata WARNING: apt does not have a stable CLI interface. Use with caution in scripts. Reading package lists... Building dependency tree... Reading state information... bison is already the newest version (2:3.8.2+dfsg-1build1). flex is already the newest version (2.6.4-8build2). libbz2-dev is already the newest version (1.0.8-5build1). libbz2-dev set to manually installed. libicu-dev is already the newest version (70.1-2). libicu-dev set to manually installed. liblz4-dev is already the newest version (1.9.3-2build2). libre2-dev is already the newest version (20220201+dfsg-1). libzstd-dev is already the newest version (1.4.8+dfsg-3build1). libzstd-dev set to manually installed. libthrift-dev is already the newest version (0.16.0-2). libcurl4-openssl-dev is already the newest version (7.81.0-1ubuntu1.16). libssl-dev is already the newest version (3.0.2-0ubuntu1.15). tzdata is already the newest version (2024a-0ubuntu0.22.04). Some packages could not be installed. This may mean that you have requested an impossible situation or if you are using the unstable distribution that some required packages have not yet been created or been moved out of Incoming. The following information may help to resolve the situation: The following packages have unmet dependencies: libgoogle-glog-dev : Depends: libunwind-dev or libunwind7-dev but it is not installable E: Unable to correct problems, you have held broken packages. ``

Let me try libunwind7-dev

We can remove non-required library, according to https://github.com/apache/incubator-gluten/blob/main/docs/developers/docker_ubuntu22.04.md

libunwind7-dev does not work either

Fix Gluten CI failure

dd2a75e

github-actions bot added kind:documentation Documentation is a feature! module:common labels Jun 4, 2024

zhouyifan279 changed the title ~~Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin~~ Jun 4, 2024

Trigger Gluten CI

5d7ad1b

github-actions bot added the kind:infra license, community building, project builds, asf infra related, etc. label Jun 4, 2024

kyuubi-util-scala:test-jar is needed

4d70a5d

github-actions bot added kind:build module:integration-tests labels Jun 4, 2024

zhouyifan279 force-pushed the gluten-ci branch from 2d07d9c to 16cefde Compare June 6, 2024 02:28

libboost_context.so not found

f7aa0ba

zhouyifan279 force-pushed the gluten-ci branch from 0eee4e3 to f7aa0ba Compare June 6, 2024 12:42

zhouyifan279 added 9 commits June 7, 2024 11:47

libboost_context.so not found

7626c1e

debug Could not find artifact org.apache.gluten:gluten-thirdparty-lib…

532e86c

…:jar

Fix Could not find artifact org.apache.gluten:gluten-thirdparty-lib:jar

e7ea815

libboost_context.so not found

028c947

libboost_context.so not found

fc0b991

debug libboost_context.so not found

0251720

libboost_context.so not found

20bb171

q3 is inconsistent

1ea91e9

q3 is inconsistent

2c8a1f1

zhouyifan279 commented Jun 10, 2024

View reviewed changes

pan3793 reviewed Jun 11, 2024

View reviewed changes

pan3793 requested a review from ulysses-you June 11, 2024 02:27

maven-os-plugin

6391c4d

pan3793 reviewed Jun 11, 2024

View reviewed changes

ulysses-you reviewed Jun 11, 2024

View reviewed changes

zhouyifan279 added 7 commits June 11, 2024 10:49

maven-os-plugin

4f1f34b

maven-os-plugin

738065f

Use gluten ./dev/package.sh

a8fd720

Upload hs_err_pid*.log

af090c2

Upload hs_err_pid*.log

706e920

Upload hs_err_pid*.log

a551244

Upload hs_err_pid*.log

a3415c8

ulysses-you reviewed Jun 26, 2024

View reviewed changes

zhouyifan279 force-pushed the gluten-ci branch from c65bd7c to a3415c8 Compare June 29, 2024 04:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

zhouyifan279 commented Jun 4, 2024

zhouyifan279 commented Jun 4, 2024

pan3793 commented Jun 4, 2024

zhouyifan279 commented Jun 4, 2024

pan3793 commented Jun 4, 2024

codecov-commenter commented Jun 4, 2024 •

edited

Loading

zhouyifan279 Jun 10, 2024

pan3793 Jun 11, 2024

zhouyifan279 Jun 11, 2024

pan3793 Jun 11, 2024

zhouyifan279 Jun 11, 2024

pan3793 Jun 11, 2024

zhouyifan279 Jun 11, 2024

pan3793 commented Jun 11, 2024

ulysses-you Jun 11, 2024 •

edited

Loading

zhouyifan279 Jun 26, 2024

zhouyifan279 commented Jun 25, 2024 •

edited

Loading

ulysses-you Jun 26, 2024

zhouyifan279 Jun 26, 2024

zhouyifan279 Jun 27, 2024

zhouyifan279 Jun 27, 2024

ulysses-you Jun 27, 2024

zhouyifan279 Jun 28, 2024

		@@ -64,6 +68,18 @@ jobs:
		git clone https://github.com/oap-project/gluten.git

[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

Are you sure you want to change the base?

[KYUUBI #6449] Fix Gluten CI ClassNotFoundException: io.glutenproject.GlutenPlugin #6449

Conversation

zhouyifan279 commented Jun 4, 2024

🔍 Description

Issue References 🔗

Describe Your Solution 🔧

Types of changes 🔖

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklist 📝

zhouyifan279 commented Jun 4, 2024

pan3793 commented Jun 4, 2024

zhouyifan279 commented Jun 4, 2024

pan3793 commented Jun 4, 2024

codecov-commenter commented Jun 4, 2024 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pan3793 commented Jun 11, 2024

ulysses-you Jun 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zhouyifan279 commented Jun 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Jun 4, 2024 •

edited

Loading

ulysses-you Jun 11, 2024 •

edited

Loading

zhouyifan279 commented Jun 25, 2024 •

edited

Loading