Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KYUUBI #3723] save the SQL session metadata into MetadataManager #3755

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lightning-L
Copy link
Contributor

Why are the changes needed?

How was this patch tested?

  • Add some test cases that check the changes thoroughly including negative and positive cases if possible

  • Add screenshots for manual tests if appropriate

  • Run test locally before make a pull request

@lightning-L
Copy link
Contributor Author

@turboFei

  • SessionData contains duration and idleTime, which is calculated by session lastAccessTime and lastIdleTime, but those two are not stored in the Metadata. How to get duration and idleTime after fetching the session metadata?
  • We could get Resource/ClassName/ClusterManager for session from engine proc builder. But before engine is created, the prod builder is null. Currently I am not sure how to set those values when opening session.
  • The batch session and sql session related operation are mixed in one class(KyuubiSessionManager), do we need a refactor? For example, separate this into KyuubiSessionManager and KyuubiBatchSessionManager.
@turboFei
Copy link
Member

turboFei commented Nov 3, 2022

SessionData contains duration and idleTime, which is calculated by session lastAccessTime and lastIdleTime, but those two are not stored in the Metadata. How to get duration and idleTime after fetching the session metadata?

Seems there is no appropriate solution now.

We could get Resource/ClassName/ClusterManager for session from engine proc builder. But before engine is created, the prod builder is null. Currently I am not sure how to set those values when opening session.

How about leave them empty now?

The batch session and sql session related operation are mixed in one class(KyuubiSessionManager), do we need a refactor? For example, separate this into KyuubiSessionManager and KyuubiBatchSessionManager.

I think it is not needed.

cc @ulysses-you @pan3793

@ulysses-you
Copy link
Contributor

session rest api is less used.. is it possible to focus on batch api ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants