Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine tuning adjustments to default header and footer #340

Merged
merged 5 commits into from
Sep 19, 2024

Conversation

beafialho
Copy link
Contributor

Description

Fine-tuning adjustments to the default header and footer:

  • Reduced top and bottom padding of the header
  • Set tagline to M instead of S font size in theme.json
  • Adjustments to footer for better scaling across devices
Copy link

github-actions bot commented Sep 17, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: beafialho <beafialho@git.wordpress.org>
Co-authored-by: juanfra <juanfra@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan
Copy link
Contributor

Footer before:

Screen.Recording.2024-09-17.at.16.15.56.mov

After:

Screen.Recording.2024-09-17.at.16.20.14.mov

Is the site title and tagline supposed to be that narrow and wrap like that on the desktop width?

Front, after:
footer

Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a block validation error in this header.
There is a group that is incomplete or not closed.

@beafialho
Copy link
Contributor Author

Is the site title and tagline supposed to be that narrow and wrap like that on the desktop width?

No 😕

Here's what I'm seeing in the editor:

Captura de ecrã 2024-09-17, às 15 29 27

And on the front end:

Captura de ecrã 2024-09-17, às 15 29 56

@beafialho
Copy link
Contributor Author

There is a block validation error in this header. There is a group that is incomplete or not closed.

I tried to change only what was necessary so I wouldn't touch the code, but I guess I missed something. I submitted another change to the footer to hopefully fix that.

@carolinan
Copy link
Contributor

The problem with the broken group block is in the header, not the footer. I'll try to help another time when I am more alert :)

@beafialho
Copy link
Contributor Author

The problem with the broken group block is in the header, not the footer. I'll try to help another time when I am more alert :)

Oops 🙈 this is what happens when the designer touches code.

The only thing I wanted to change in the header was to set the top and bottom spacing of the row to spacing-30 instead of spacing-40.

Thank you for the help, no urgency!

Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.
⚠️ Note: The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

Copy link
Member

@juanfra juanfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Bea!

I've fixed the block validation issue and worked on the indent of the footer.

Looks good to me

Screen.Recording.2024-09-19.at.15.56.23.mov
@juanfra juanfra merged commit 2b78e46 into trunk Sep 19, 2024
5 checks passed
@juanfra juanfra deleted the adjustments-default-header-footer branch September 19, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants