Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to handle users who have earned no points within a period #5

Open
JDGrimes opened this issue Mar 24, 2017 · 0 comments
Open

How to handle users who have earned no points within a period #5

JDGrimes opened this issue Mar 24, 2017 · 0 comments
Labels

Comments

@JDGrimes
Copy link
Member

Something that we'll have to decide is how to handle users who have not earned any points in a given period.

In the wordpoints_points_get_top_users() function in core, we query the users table with a LEFT JOIN on the usermeta table. Essentially, we include the users with no points in the list of top users. This is partly because of complaints about the table being empty, or not showing some users. Or really, I guess it was about the table showing less than the number of requested users. But the reason for that was because the site did not have very many users with points yet.

Showing the non-earners in the table makes the query more expensive, and it really has little value, as far as I can tell, so I'm leaning against it. Instead, I'd suggest that we add a row that contains a message that there were no more points earners within the period, or something to that effect.

@JDGrimes JDGrimes added this to the 1.0.0 milestone Mar 24, 2017
@JDGrimes JDGrimes mentioned this issue Mar 24, 2017
JDGrimes added a commit that referenced this issue Apr 19, 2017
A user can loose points within a period rather than gaining.

See #4, #5
@JDGrimes JDGrimes removed this from the 1.0.0 milestone May 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 participant