Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvements #47

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Performance improvements #47

merged 1 commit into from
Jun 2, 2020

Conversation

prydin
Copy link
Contributor

@prydin prydin commented Jun 2, 2020 •
edited
Loading

After running my code in JProfiler, I found that a lot of time was spent in the numeric array reading methods. It turns out that length() and getValue() on the array tag were called tens of millions of times. Optimizing this part of the code cut the time to load a 1000x1000 map by 2-4 seconds.
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 89.352% when pulling e6cb656 on prydin:prydin-heightmap into c66dd6d on Querz:master.
@Querz Querz merged commit 0755fe5 into Querz:master Jun 2, 2020
@prydin prydin deleted the prydin-heightmap branch June 2, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@prydin @coveralls @Querz