Squiz/DisallowMultipleAssignments: fix sniff walking back too far when going in/out of PHP #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Fantastic, thanks for putting this fix together so quickly @jrfnl. Looks good to me and a thorough range of test cases to cover variations. I've tested this with my original code that brought this issue up for me and it works perfectly. |
|
While reviewing this PR, I found another false positive that could happen when live coding. The following code triggers the sniff and it should not: function missingClosingParenthesis($a =I have a fix ready and I will create a new PR once this one is merged to avoid conflicts. |
4 tasks
|
I opened an issue to document the bug that I described above which is probably which I should have done in the first place instead of reporting the problem here in the comment above: #551 |
…n going in/out of PHP The sniff did not recognize that when it would encounter a PHP close tag, it had reached a previous statement, leading to false positives for list assignments. Fixed now. Includes tests. Fixes 537
jrfnl
force-pushed
the
feature/537-squiz-disallowmultipleassignments-bug-fix
branch
from
bf3d6f5
to
17731a1
Compare
|
Rebased without changes. Merging once the build has passed. |
54 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The sniff did not recognize that when it would encounter a PHP close tag, it had reached a previous statement, leading to false positives for list assignments.
Fixed now. Includes tests.
Suggested changelog entry
Squiz.PHP.DisallowMultipleAssignments false positive for list assignments at the start of a new PHP block after an embedded PHP statement.
Related issues/external references
Fixes #537
Types of changes