Skip to:
Content

BuddyPress.org

Opened 4 months ago

Last modified 9 days ago

#9174 assigned task

WPCS improvements for 15.0

Reported by: espellcaste's profile espellcaste Owned by: espellcaste's profile espellcaste
Milestone: 15.0.0 Priority: normal
Severity: normal Version:
Component: Core Keywords: has-patch
Cc:

Description

Previously:

Change History (17)

#1 @espellcaste
4 months ago

  • Summary changed from WPCS Improvements for 15.0 to WPCS improvements for 15.0

#2 @johnjamesjacoby
3 months ago

In 13927:

WPCS: param & global docs corrections.

Some were missing, out-of-order, or potentially wrong based on conditional logic (I.E. when specific class names are juggled based on Site/Network admin area contexts). For those, I opted just to use "object" rather than the exact class names, because they're lengthy & ugly & make the docs more difficult to read. Feel free to override that decision later!

See: #9174.

#3 @espellcaste
3 months ago

For those, I opted just to use "object" rather than the exact class names, because they're lengthy & ugly & make the docs more difficult to read. Feel free to override that decision later!

I'm not opposed to this change but two arguments for adding the object class is IDE support (intelephense) and it makes more clearer about its value.

In a IDE, like vscode, one can't go to that particular class anymore, since it is an anonymous object. One can't also tell what's the object real class, which properties this object support, if it does.

Essentially, one loses intelephense support, which is helpful while developing and we would be documenting the variable's true value.

If the $global value accepts both an anonymous object and BP_Optouts_List_Table, I'd advocate adding both there.

docs more difficult to read

I'd argue it makes it lenthy, not difficult to read. But I'd accept this is just my opinion.

#5 @imath
3 months ago

  • Milestone changed from Up Next to 15.0.0

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


2 months ago

#8 @espellcaste
2 months ago

In 13968:

WPCS: Part XII: miscellaneous fixes for some of the files of the core component.

Follow-up to [13904]

See #9174 and #9173

#9 @espellcaste
2 months ago

In 13971:

WPCS: miscellaneous fixes for cache-related files in several components.

See #9174 and #9173
Closes https://github.com/buddypress/buddypress/pull/331

#10 @espellcaste
2 months ago

In 13972:

WPCS: stop some rules from being applied to the project.

This is a preliminary list that can be extended or updated afterwards.

See #9174

#11 @espellcaste
8 weeks ago

In 13992:

PHPDoc: Update bp_core_set_incremented_cache to better reflect the accepted value to store in the cache.

See #9174

#12 @espellcaste
3 weeks ago

In 14010:

WPCS: Part I: miscellaneous fixes for some of the files of the blogs component.

See #9174
See #9173

This ticket was mentioned in PR #366 on buddypress/buddypress by renatonascalves.


3 weeks ago
#14

Apply phpcbf to the activity component so that we can fix automatic styling issues in bulk.

Trac ticket: https://buddypress.trac.wordpress.org/ticket/9174

This ticket was mentioned in Slack in #buddypress by espellcaste. View the logs.


3 weeks ago

#16 @espellcaste
2 weeks ago

In 14016:

WPCS: append some new rules from being applied to the project.

Follow-up from [13972].

See #9174

#17 @imath
9 days ago

In 14022:

WPCS: improve BP Nouveau's main functions file code formatting.

Props narenin

Fixes #9230
See #9174
Closes https://github.com/buddypress/buddypress/pull/372

Note: See TracTickets for help on using tickets.