Added clarifying points for hostname and address parameters #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm setting pump.io for the first time, and the details that I added here were definitely the biggest points of struggle in the process.
|
@bcomnes looks like this got closed accidentally - I would be happy to take a MR for this over at https://gitlab.com/pump.io/pump-docs if you want to! |
|
I've completely lost context on whatever it was I found out at the time. Anyone else can feel free too if its still relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm setting pump.io for the first time, and the details that I added here were definitely the biggest points of struggle in the process.
Once I was informed of these differences in IRC, hosting from behind a router made sense to me.
Also, with regards to the Making Changes section, maybe we should reference that section from every parameter that it applies to? I only added a reference to the hostname section.